Skip to content

[Bugfix][V0] XGrammar structured output supports Enum #15878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

[Bugfix][V0] XGrammar structured output supports Enum #15878

merged 1 commit into from
Apr 7, 2025

Conversation

@leon-seidel
Copy link
Contributor

@leon-seidel leon-seidel commented Apr 1, 2025

XGrammar Enums support was added for V1 ( #15594) but not for V0 yet. This PR mirrors the fix and the test from their V1 counterpart.

@github-actions
Copy link

github-actions bot commented Apr 1, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@njhill njhill added the v0 label Apr 1, 2025
@ItzAmirreza
Copy link

ItzAmirreza commented Apr 4, 2025

Really need this! Thank you for PR.

russellb
russellb approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@russellb russellb enabled auto-merge (squash) April 7, 2025 13:28
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 7, 2025
@leon-seidel @russellb
Enums for XGrammar with V0
aa1b82f 
Signed-off-by: Leon Seidel <leon.seidel@fau.de>
@russellb
Copy link
Member

russellb commented Apr 7, 2025

I just rebased this on main to see if that picks up CI fixes

@russellb russellb merged commit 24f1c01 into vllm-project:main Apr 7, 2025
41 checks passed
@russellb russellb mentioned this pull request Apr 9, 2025
Closed
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@leon-seidel @yangw-dev
[Bugfix][V0] XGrammar structured output supports Enum (vllm-project#1…
97e6d47 
…5878)

Signed-off-by: Leon Seidel <leon.seidel@fau.de>
Signed-off-by: Yang Wang <elainewy@meta.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@leon-seidel @lk-chen
[Bugfix][V0] XGrammar structured output supports Enum (vllm-project#1…
286fc69 
…5878)

Signed-off-by: Leon Seidel <leon.seidel@fau.de>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@leon-seidel
[Bugfix][V0] XGrammar structured output supports Enum (vllm-project#1…
95a79a3 
…5878)

Signed-off-by: Leon Seidel <leon.seidel@fau.de>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@russellb russellb russellb approved these changes

@mgoin mgoin Awaiting requested review from mgoin

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed structured-output v0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@leon-seidel @ItzAmirreza @russellb @njhill